test_runner: improve wait_until

[erikgrinaker]

Improves wait_until by:

• Use timeout instead of iterations. This allows changing the timeout/interval parameters independently.
• Make timeout and interval optional (default 20s and 0.5s). Most callers don't care.
• Only output status every 1s by default, and add optional status_interval parameter.
• Remove show_intermediate_error, this was always emitted anyway.

Most callers have been updated to use the defaults, except where they had good reason otherwise.

[github-actions]

7018 tests run: 6710 passed, 0 failed, 308 skipped (full report)

---

Flaky tests (1)

Postgres 15

• test_pull_timeline[True]: release-arm64

Code coverage* (full report)

• functions: 30.4% (8276 of 27226 functions)
• lines: 47.8% (65239 of 136512 lines)

* collected from Rust tests only

---

_{The comment gets automatically updated with the latest test results
5e7ca9d at 2024-12-02T10:26:58.081Z :recycle:}

[jcsp]

I'm in favour, always found this function kind of weird.

One note of caution: the use of defaults in so many places means that these default values are going to become somewhat sacred, as ever changing them will likely destabilise some tests.

[erikgrinaker]

One note of caution: the use of defaults in so many places means that these default values are going to become somewhat sacred, as ever changing them will likely destabilise some tests.

Yeah, that's always a risk here. I figure 20 seconds is enough to cover practically all common cases and still low enough not to be annoying. Many of the explicit timeouts were also either 20 or 30 seconds, and this seemed to have been mostly arbitrary.

[erikgrinaker]

Will hold off on this until Monday, to avoid any weekend CI breakage.