remote_storage/abs: count 404 and 304 for get as ok for metrics #9912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem We currently see elevated levels of errors for GetBlob requests. This is because 404 and 304 are counted as errors for metric reporting. Summary of Changes Bring the implementation in line with the S3 client and treat 404 and 304 responses as ok for metric purposes.
VladLazar
requested review from
arssher and
arpad-m
and removed request for
arssher
arpad-m
approved these changes
Nov 27, 2024
6967 tests run: 6659 passed, 0 failed, 308 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
ff1dc52 at 2024-11-28T10:21:57.889Z :recycle: |
awarus
pushed a commit
that referenced
this pull request
Dec 5, 2024
## Problem We currently see elevated levels of errors for GetBlob requests. This is because 404 and 304 are counted as errors for metric reporting. ## Summary of Changes Bring the implementation in line with the S3 client and treat 404 and 304 responses as ok for metric purposes. Related: neondatabase/cloud#20666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We currently see elevated levels of errors for GetBlob requests. This is because 404 and 304 are counted as errors for metric reporting.
Summary of Changes
Bring the implementation in line with the S3 client and treat 404 and 304 responses as ok for metric purposes.
Related: https://github.com/neondatabase/cloud/issues/20666