Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: add relsize cache metrics #9890

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Nov 26, 2024

Problem

We don't have any observability for the relation size cache. We have seen cache misses cause significant performance impact with high relation counts.

Touches #9855.

Summary of changes

Adds the following metrics:

  • pageserver_relsize_cache_entries
  • pageserver_relsize_cache_hits
  • pageserver_relsize_cache_misses
  • pageserver_relsize_cache_misses_old

@erikgrinaker erikgrinaker requested a review from a team as a code owner November 26, 2024 09:38
Copy link

github-actions bot commented Nov 26, 2024

6941 tests run: 6633 passed, 0 failed, 308 skipped (full report)


Code coverage* (full report)

  • functions: 30.7% (7982 of 26019 functions)
  • lines: 48.6% (63353 of 130437 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6669986 at 2024-11-27T13:51:18.524Z :recycle:

@erikgrinaker erikgrinaker added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit e4f437a Nov 27, 2024
80 checks passed
@erikgrinaker erikgrinaker deleted the erik/relsize-cache-metrics branch November 27, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants