Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track how much time the flush loop is stalled waiting for uploads #9885

Merged
merged 11 commits into from
Nov 26, 2024

Conversation

Bodobolero
Copy link
Contributor

@Bodobolero Bodobolero commented Nov 25, 2024

Problem

We don't know how much time PS is losing during ingest when waiting for remote storage uploads in the flush frozen layer loop.
Also we don't know how many remote storage requests get an permit without waiting (not throttled by remote_storage concurrency_limit).

Summary of changes

Update: created a new version that uses a Gauge (one increasing value per PS/shard) instead of histogram as suggested by review

@Bodobolero Bodobolero requested a review from a team as a code owner November 25, 2024 15:57
pageserver/src/metrics.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@jcsp jcsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's think about whether we want to take the cost of the histogram long term

@Bodobolero Bodobolero requested review from jcsp and arpad-m November 25, 2024 19:14
Copy link

github-actions bot commented Nov 25, 2024

6941 tests run: 6633 passed, 0 failed, 308 skipped (full report)


Code coverage* (full report)

  • functions: 30.9% (7977 of 25851 functions)
  • lines: 48.6% (63315 of 130182 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b9793ab at 2024-11-26T11:41:15.146Z :recycle:

libs/remote_storage/src/metrics.rs Show resolved Hide resolved
@Bodobolero Bodobolero enabled auto-merge November 26, 2024 09:32
@Bodobolero Bodobolero added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 13feda0 Nov 26, 2024
80 checks passed
@Bodobolero Bodobolero deleted the bodobolero/ps_upload_wait_metric branch November 26, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants