Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): queue stopped error should be ignored during create timeline #9767

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Nov 14, 2024

Problem

close #9730

The test case tests if anything goes wrong during pageserver restart + during timeline creation not complete. Therefore, queue is stopped error is normal in this case, except that it should be categorized as a shutdown error instead of a real error.

Summary of changes

  • More comments for the test case.
  • Queue stopped error will now be forwarded as CreateTimelineError::ShuttingDown.

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from jcsp November 14, 2024 22:08
Copy link

github-actions bot commented Nov 14, 2024

5490 tests run: 5264 passed, 0 failed, 226 skipped (full report)


Code coverage* (full report)

  • functions: 31.5% (7931 of 25167 functions)
  • lines: 49.6% (62843 of 126583 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b7b2b53 at 2024-11-18T19:01:18.136Z :recycle:

@skyzh
Copy link
Member Author

skyzh commented Nov 15, 2024

ahh... seems like wait_for_tenant_active is not the right function to use

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from a team as a code owner November 18, 2024 17:45
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh changed the title fix(test): wait for tenant ready before churn fix(pageserver): queue stopped error should be ignored during create timeline Nov 18, 2024
@skyzh
Copy link
Member Author

skyzh commented Nov 18, 2024

removed wait for tenant to start and assume the test case also tests the case where the timeline doesn't initialize before restart. ready for review.

@skyzh skyzh merged commit 5e3fbef into main Nov 19, 2024
78 checks passed
@skyzh skyzh deleted the skyzh/fix-test-unstable branch November 19, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instability in test_create_churn_during_restart
2 participants