Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safekeeper: use WAL_SEGMENT_SIZE for empty timeline state #9734

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

erikgrinaker
Copy link
Contributor

Problem

TimelinePersistentState::empty(), used for tests and benchmarks, had a hardcoded 16 MB WAL segment size. This caused confusion when attempting to change the global segment size.

Summary of changes

Inherit from WAL_SEGMENT_SIZE in TimelinePersistentState::empty().

@erikgrinaker erikgrinaker self-assigned this Nov 12, 2024
@erikgrinaker erikgrinaker requested a review from a team as a code owner November 12, 2024 17:19
@erikgrinaker erikgrinaker requested a review from arpad-m November 12, 2024 17:19
@erikgrinaker erikgrinaker enabled auto-merge (squash) November 12, 2024 17:19
Copy link

5382 tests run: 5162 passed, 0 failed, 220 skipped (full report)


Flaky tests (2)

Postgres 17

Code coverage* (full report)

  • functions: 31.8% (7888 of 24834 functions)
  • lines: 49.5% (62456 of 126258 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
7f352d9 at 2024-11-12T18:55:48.972Z :recycle:

@erikgrinaker erikgrinaker merged commit 2256a57 into main Nov 12, 2024
82 checks passed
@erikgrinaker erikgrinaker deleted the erik/segment-size-tps branch November 12, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants