Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): increase frozen layer warning threshold; ignore in tests #9705

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Nov 9, 2024

Problem

Perf benchmarks produce a lot of layers.

Summary of changes

Bumping the threshold and ignore the warning.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh requested a review from bayandin November 9, 2024 19:40
@skyzh skyzh requested a review from a team as a code owner November 9, 2024 19:40
@skyzh skyzh requested a review from arssher November 9, 2024 19:40
Copy link

github-actions bot commented Nov 9, 2024

5446 tests run: 5212 passed, 2 failed, 232 skipped (full report)


Failures on Postgres 16

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_sharded_ingest[release-pg16-github-actions-selfhosted-1] or test_compaction_l0_memory[release-pg16-github-actions-selfhosted]"
Flaky tests (3)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 31.7% (7867 of 24806 functions)
  • lines: 49.4% (62259 of 126036 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
976edf9 at 2024-11-10T22:03:28.802Z :recycle:

…ests

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/frozen-layer-warning-threshold branch from 57445a5 to 9145c45 Compare November 10, 2024 00:31
@skyzh skyzh added the run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label label Nov 10, 2024
Signed-off-by: Alex Chi Z <chi@neon.tech>
@bayandin
Copy link
Member

FYI, failed benchmarks don't block the merge, so we can merge the PR

@skyzh skyzh merged commit 48c06d9 into main Nov 11, 2024
82 of 84 checks passed
@skyzh skyzh deleted the skyzh/frozen-layer-warning-threshold branch November 11, 2024 14:13
skyzh added a commit that referenced this pull request Nov 11, 2024
…ests (#9705)

Perf benchmarks produce a lot of layers.

## Summary of changes

Bumping the threshold and ignore the warning.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants