Create a branch for compute release #9637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-masterov
force-pushed
the
amasterov/release-compute
branch
from
e5db27f to
4534f5c
Compare
7029 tests run: 6721 passed, 0 failed, 308 skipped (full report)Flaky tests (3)Postgres 17
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
045ef92 at 2024-12-04T12:43:52.253Z :recycle: |
…amasterov/release-compute
bayandin
reviewed
Nov 8, 2024
There was a problem hiding this comment.
I see mentions of release-proxy workflow in a couple of more files:
$ git grep -l release-proxy
.github/actions/allure-report-generate/action.yml
.github/actions/allure-report-store/action.yml
.github/workflows/build_and_test.yml
.github/workflows/release.yml
.github/workflows/trigger-e2e-tests.yml
Do we need to update them to take into account release-compute?
bayandin
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Well done! Left a couple of suggestions and we're good to go!
Before merging we need to:
- create
release-computebranch (fromrelease)
Right after the merge:
- ask to use a
release-computebranch instead ofrelease(and a proper parameter forrelease.ymlworkflow) - let people know that for compute releases they should use
release-compute-prefixed tag (instead ofrelease-)
bayandin
added a commit
that referenced
this pull request
Nov 19, 2024
## Problem We have a bunch of duplicated code for automated releases. There will be even more, once we have `release-compute` branch (#9637). Another issue with the current `release` workflow is that it creates a PR from the main as is. If we create 2 different releases from the same commit, GitHub could mix up results from different PRs. ## Summary of changes - Create a reusable workflow for releases - Create an empty commit to differentiate releases
a-masterov
changed the title
# Conflicts: # .github/workflows/release.yml
bayandin
approved these changes
Nov 30, 2024
awarus
pushed a commit
that referenced
this pull request
Dec 5, 2024
## Problem We practice a manual release flow for the compute module. This will allow automation of the compute release process. ## Summary of changes The workflow was modified to make a compute release automatically on the branch release-compute. ## Checklist before requesting a review - [x] I have performed a self-review of my code. - [ ] If it is a core feature, I have added thorough tests. - [ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard? - [ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section. ## Checklist before merging - [ ] Do not forget to reformat commit message to not include the above checklist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We practice a manual release flow for the compute module. This will allow automation of the compute release process.
Summary of changes
The workflow was modified to make a compute release automatically on the branch release-compute.
Checklist before requesting a review
Checklist before merging