Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename IndexPart::{from_s3_bytes,to_s3_bytes} #9481

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Rename IndexPart::{from_s3_bytes,to_s3_bytes} #9481

merged 1 commit into from
Oct 22, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Oct 22, 2024

We support multiple storage backends now, so remove the _s3_ from the name.

Analogous to the names adopted for tenant manifests added in #9444.

@arpad-m arpad-m requested a review from erikgrinaker October 22, 2024 15:28
@arpad-m arpad-m requested a review from a team as a code owner October 22, 2024 15:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 22, 2024 •
edited
Loading

5255 tests run: 5041 passed, 0 failed, 214 skipped (full report)

Flaky tests (4)

Postgres 17

Code coverage* (full report)

  • functions: 31.4% (7669 of 24396 functions)
  • lines: 48.9% (60262 of 123123 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
4f28032 at 2024-10-22T21:09:41.549Z :recycle:

erikgrinaker
erikgrinaker approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arpad-m arpad-m merged commit 3a3bd34 into main Oct 22, 2024
83 checks passed
@arpad-m arpad-m deleted the arpad/remove_s3_from_name branch October 22, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgrinaker erikgrinaker erikgrinaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arpad-m @erikgrinaker