Add neon.logical_replication_max_logicalsnapdir_size #9467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristan957
force-pushed
the
tristan957/snap
branch
from
261a9ec to
8cfe3e9
Compare
tristan957
force-pushed
the
tristan957/snap
branch
from
8cfe3e9 to
23015c0
Compare
5382 tests run: 5162 passed, 0 failed, 220 skipped (full report)Flaky tests (2)Postgres 17
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
cc1f9ce at 2024-11-12T00:11:42.540Z :recycle: |
tristan957
force-pushed
the
tristan957/snap
branch
from
23015c0 to
b1fcf59
Compare
tristan957
force-pushed
the
tristan957/snap
branch
from
b1fcf59 to
27d509a
Compare
|
Perhaps logical_replication_max_logicalsnapdir_size should be renamed logical_replication_max_snapdir_size |
tristan957
force-pushed
the
tristan957/snap
branch
2 times, most recently
from
03dbad0 to
5aa0fe6
Compare
erikgrinaker
approved these changes
Oct 30, 2024
knizhnik
reviewed
Nov 8, 2024
tristan957
force-pushed
the
tristan957/snap
branch
from
5aa0fe6 to
42c7145
Compare
skyzh
approved these changes
Nov 11, 2024
tristan957
force-pushed
the
tristan957/snap
branch
from
42c7145 to
d5aac75
Compare
This GUC will drop replication slots if the size of the pg_logical/snapshots directory (not including temp snapshot files) becomes larger than the specified size. Keeping the size of this directory smaller will help with basebackup size from the pageserver. Part-of: #8619 Signed-off-by: Tristan Partin <tristan@neon.tech>
tristan957
force-pushed
the
tristan957/snap
branch
from
d5aac75 to
cc1f9ce
Compare
knizhnik
approved these changes
Nov 12, 2024
skyzh
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This GUC will drop replication slots if the size of the pg_logical/snapshots directory (not including temp snapshot files) becomes larger than the specified size. Keeping the size of this directory smaller will help with basebackup size from the pageserver.