Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_compatibility: flush in the end #8804

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

koivunej
Copy link
Member

@koivunej koivunej commented Aug 22, 2024

test_forward_compatibility is still often failing at graceful shutdown. Fix this by explicit flush before shutdown.

Example: https://neon-github-public-dev.s3.amazonaws.com/reports/main/10506613738/index.html#testresult/5e7111907f7ecfb2/

Cc: #8655 and #8708
Previous attempt: #8787

@koivunej koivunej changed the title test_compatibility: wait for wal recovery, flush test_compatibility: flush in the end Aug 22, 2024
@koivunej koivunej requested a review from bayandin August 22, 2024 14:47
@koivunej koivunej force-pushed the joonas/test_compatiblity_graceful branch from 7093eb6 to 1fa3f89 Compare August 22, 2024 14:48
Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@koivunej koivunej enabled auto-merge (squash) August 22, 2024 14:56
@koivunej koivunej merged commit b1c4578 into main Aug 22, 2024
63 checks passed
@koivunej koivunej deleted the joonas/test_compatiblity_graceful branch August 22, 2024 15:38
Copy link

3801 tests run: 3695 passed, 0 failed, 106 skipped (full report)


Flaky tests (2)

Postgres 16

  • test_subscriber_synchronous_commit: release
  • test_subscriber_restart: debug

Code coverage* (full report)

  • functions: 32.4% (7237 of 22342 functions)
  • lines: 50.4% (58528 of 116127 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
1fa3f89 at 2024-08-22T15:40:24.592Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants