Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compute_logical_snapshot_files metric #8762

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

tristan957
Copy link
Member

@tristan957 tristan957 commented Aug 19, 2024

Track the number of logical snapshot files on an endpoint over time.

Closes #6626

@tristan957 tristan957 requested a review from ololobus August 19, 2024 21:35
@tristan957
Copy link
Member Author

In one of my other PRs, Alexey had suggested prefixing compute metrics with compute_. I haven't done that for this PR yet, assuming he wants the same thing.

Copy link

github-actions bot commented Aug 19, 2024

2172 tests run: 2108 passed, 0 failed, 64 skipped (full report)


Code coverage* (full report)

  • functions: 32.4% (7233 of 22321 functions)
  • lines: 50.4% (58440 of 115981 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
e192fee at 2024-08-20T16:49:21.589Z :recycle:

Copy link
Member

@ololobus ololobus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reference issue #6626 and/or #8619 for the context

vm-image-spec.yaml Outdated Show resolved Hide resolved
vm-image-spec.yaml Outdated Show resolved Hide resolved
vm-image-spec.yaml Outdated Show resolved Hide resolved
Track the number of logical snapshot files on an endpoint over time.

Signed-off-by: Tristan Partin <tristan@neon.tech>
@tristan957 tristan957 force-pushed the tristan957/replication/logical_snapshot_files branch from 8d74877 to e192fee Compare August 20, 2024 15:59
@tristan957 tristan957 changed the title Add logical_snapshot_files metric Add compute_logical_snapshot_files metric Aug 20, 2024
Copy link
Member

@ololobus ololobus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Didn't realize that there is an existing func/view pg_ls_logicalsnapdir for that

@tristan957 tristan957 merged commit f4b3c31 into main Aug 21, 2024
60 of 63 checks passed
@tristan957 tristan957 deleted the tristan957/replication/logical_snapshot_files branch August 21, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Severe bloat in AUX files storage on the pageserver
2 participants