Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: increase rate limit duration for layer visit log #8263

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

VladLazar
Copy link
Contributor

Problem

I'd like to keep this in the tree since it might be useful in prod as well.
It's a bit too noisy as is and missing the lsn.

Summary of changes

Add an lsn field and and increase the rate limit duration.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@VladLazar VladLazar requested a review from a team as a code owner July 4, 2024 10:46
@VladLazar VladLazar requested review from yliang412 and koivunej and removed request for yliang412 July 4, 2024 10:46
Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the ratelimit 10s -> 60s oki.

Copy link

github-actions bot commented Jul 4, 2024

3006 tests run: 2891 passed, 0 failed, 115 skipped (full report)


Flaky tests (1)

Postgres 14

Code coverage* (full report)

  • functions: 32.7% (6936 of 21223 functions)
  • lines: 50.1% (54444 of 108707 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
32de20e at 2024-07-04T11:50:19.950Z :recycle:

@VladLazar VladLazar merged commit a462537 into main Jul 4, 2024
64 of 65 checks passed
@VladLazar VladLazar deleted the vlad/increase-many-layers-log-interval branch July 4, 2024 12:22
VladLazar added a commit that referenced this pull request Jul 8, 2024
## Problem
I'd like to keep this in the tree since it might be useful in prod as
well. It's a bit too noisy as is and missing the lsn.

## Summary of changes
Add an lsn field and and increase the rate limit duration.
VladLazar added a commit that referenced this pull request Jul 8, 2024
## Problem
I'd like to keep this in the tree since it might be useful in prod as
well. It's a bit too noisy as is and missing the lsn.

## Summary of changes
Add an lsn field and and increase the rate limit duration.
VladLazar added a commit that referenced this pull request Jul 8, 2024
## Problem
I'd like to keep this in the tree since it might be useful in prod as
well. It's a bit too noisy as is and missing the lsn.

## Summary of changes
Add an lsn field and and increase the rate limit duration.
VladLazar added a commit that referenced this pull request Jul 8, 2024
## Problem
I'd like to keep this in the tree since it might be useful in prod as
well. It's a bit too noisy as is and missing the lsn.

## Summary of changes
Add an lsn field and and increase the rate limit duration.
VladLazar added a commit that referenced this pull request Jul 8, 2024
## Problem
I'd like to keep this in the tree since it might be useful in prod as
well. It's a bit too noisy as is and missing the lsn.

## Summary of changes
Add an lsn field and and increase the rate limit duration.
VladLazar added a commit that referenced this pull request Jul 8, 2024
## Problem
I'd like to keep this in the tree since it might be useful in prod as
well. It's a bit too noisy as is and missing the lsn.

## Summary of changes
Add an lsn field and and increase the rate limit duration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants