Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI(pg-clients): unify workflow with build-and-test #8160

Merged
merged 4 commits into from
Jul 4, 2024
Merged

CI(pg-clients): unify workflow with build-and-test #8160

merged 4 commits into from
Jul 4, 2024

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Jun 25, 2024 •
edited
Loading

Problem

The pg-clients workflow looks different from the main build-and-test workflow for historical reasons (it was my very first task at Neon, back then I wasn't really familiar with the rest of the CI pipelines).
This PR unifies pg-clients workflow with build-and-test

Summary of changes

  • Rename pg_clients.yml to pg-clients.yml
  • Run the workflow on changes in relevant files
  • Create Allure report for tests
  • Update Client libraries once we're here
  • Send slack notifications to #on-call-qa-staging-stream channel (instead of #on-call-staging-stream)

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@bayandin bayandin added the run-no-ci Don't run any CI for this PR. label Jun 25, 2024
@bayandin bayandin force-pushed the bayandin/unify-pg_clients-tests branch from 6ca41ae to 142079d Compare June 25, 2024 15:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited
Loading

3006 tests run: 2891 passed, 0 failed, 115 skipped (full report)

Flaky tests (1)

Postgres 14

Code coverage* (full report)

  • functions: 32.7% (6935 of 21223 functions)
  • lines: 50.1% (54433 of 108707 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
5f0ad23 at 2024-07-04T13:48:52.658Z :recycle:

@bayandin bayandin force-pushed the bayandin/unify-pg_clients-tests branch 4 times, most recently from 45c843a to 453c661 Compare June 27, 2024 14:25
@bayandin bayandin marked this pull request as ready for review June 27, 2024 17:53
@bayandin bayandin removed the run-no-ci Don't run any CI for this PR. label Jun 27, 2024
@bayandin bayandin force-pushed the bayandin/unify-pg_clients-tests branch 6 times, most recently from 3cdf450 to a643f92 Compare July 3, 2024 19:45
@bayandin bayandin added the run-no-ci Don't run any CI for this PR. label Jul 3, 2024
@bayandin bayandin force-pushed the bayandin/unify-pg_clients-tests branch from 6851894 to 117f888 Compare July 3, 2024 22:33
@bayandin bayandin removed the run-no-ci Don't run any CI for this PR. label Jul 3, 2024
@bayandin bayandin force-pushed the bayandin/unify-pg_clients-tests branch from 117f888 to 008f401 Compare July 3, 2024 22:43
@bayandin bayandin requested a review from a-masterov July 3, 2024 23:10
a-masterov
a-masterov reviewed Jul 4, 2024
View reviewed changes
Dockerfile.build-tools Outdated Show resolved Hide resolved
@bayandin bayandin requested a review from a-masterov July 4, 2024 13:11
a-masterov
a-masterov approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@a-masterov a-masterov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems found

@bayandin bayandin merged commit bf9fc77 into main Jul 4, 2024
86 checks passed
@bayandin bayandin deleted the bayandin/unify-pg_clients-tests branch July 4, 2024 13:58
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
@bayandin @VladLazar
CI(pg-clients): unify workflow with build-and-test (#8160)
04741fc 
## Problem

`pg-clients` workflow looks different from the main `build-and-test`
workflow for historical reasons (it was my very first task at Neon, and 
back then I wasn't really familiar with the rest of the CI pipelines).
This PR unifies `pg-clients` workflow with `build-and-test`

## Summary of changes
- Rename `pg_clients.yml` to `pg-clients.yml`
- Run the workflow on changes in relevant files
- Create Allure report for tests
- Send slack notifications to `#on-call-qa-staging-stream` channel
(instead of `#on-call-staging-stream`)
- Update Client libraries once we're here
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
@bayandin @VladLazar
CI(pg-clients): unify workflow with build-and-test (#8160)
dfda32f 
## Problem

`pg-clients` workflow looks different from the main `build-and-test`
workflow for historical reasons (it was my very first task at Neon, and 
back then I wasn't really familiar with the rest of the CI pipelines).
This PR unifies `pg-clients` workflow with `build-and-test`

## Summary of changes
- Rename `pg_clients.yml` to `pg-clients.yml`
- Run the workflow on changes in relevant files
- Create Allure report for tests
- Send slack notifications to `#on-call-qa-staging-stream` channel
(instead of `#on-call-staging-stream`)
- Update Client libraries once we're here
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
@bayandin @VladLazar
CI(pg-clients): unify workflow with build-and-test (#8160)
ce8fdd0 
## Problem

`pg-clients` workflow looks different from the main `build-and-test`
workflow for historical reasons (it was my very first task at Neon, and 
back then I wasn't really familiar with the rest of the CI pipelines).
This PR unifies `pg-clients` workflow with `build-and-test`

## Summary of changes
- Rename `pg_clients.yml` to `pg-clients.yml`
- Run the workflow on changes in relevant files
- Create Allure report for tests
- Send slack notifications to `#on-call-qa-staging-stream` channel
(instead of `#on-call-staging-stream`)
- Update Client libraries once we're here
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
@bayandin @VladLazar
CI(pg-clients): unify workflow with build-and-test (#8160)
66dbb5a 
## Problem

`pg-clients` workflow looks different from the main `build-and-test`
workflow for historical reasons (it was my very first task at Neon, and 
back then I wasn't really familiar with the rest of the CI pipelines).
This PR unifies `pg-clients` workflow with `build-and-test`

## Summary of changes
- Rename `pg_clients.yml` to `pg-clients.yml`
- Run the workflow on changes in relevant files
- Create Allure report for tests
- Send slack notifications to `#on-call-qa-staging-stream` channel
(instead of `#on-call-staging-stream`)
- Update Client libraries once we're here
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
@bayandin @VladLazar
CI(pg-clients): unify workflow with build-and-test (#8160)
9acc561 
## Problem

`pg-clients` workflow looks different from the main `build-and-test`
workflow for historical reasons (it was my very first task at Neon, and 
back then I wasn't really familiar with the rest of the CI pipelines).
This PR unifies `pg-clients` workflow with `build-and-test`

## Summary of changes
- Rename `pg_clients.yml` to `pg-clients.yml`
- Run the workflow on changes in relevant files
- Create Allure report for tests
- Send slack notifications to `#on-call-qa-staging-stream` channel
(instead of `#on-call-staging-stream`)
- Update Client libraries once we're here
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
@bayandin @VladLazar
CI(pg-clients): unify workflow with build-and-test (#8160)
0e48323 
## Problem

`pg-clients` workflow looks different from the main `build-and-test`
workflow for historical reasons (it was my very first task at Neon, and 
back then I wasn't really familiar with the rest of the CI pipelines).
This PR unifies `pg-clients` workflow with `build-and-test`

## Summary of changes
- Rename `pg_clients.yml` to `pg-clients.yml`
- Run the workflow on changes in relevant files
- Create Allure report for tests
- Send slack notifications to `#on-call-qa-staging-stream` channel
(instead of `#on-call-staging-stream`)
- Update Client libraries once we're here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-masterov a-masterov a-masterov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bayandin @a-masterov