Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: allow neon extension auto-upgrade + softfail upgrade #7231

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Mar 25, 2024

Problem

reverts #7128, unblocks https://github.com/neondatabase/cloud/issues/10742

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

skyzh added 2 commits March 25, 2024 11:33
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh marked this pull request as ready for review March 25, 2024 15:35
@skyzh skyzh requested review from a team as code owners March 25, 2024 15:35
@skyzh skyzh requested review from NanoBjorn and knizhnik March 25, 2024 15:35
Copy link

github-actions bot commented Mar 25, 2024

2748 tests run: 2609 passed, 0 failed, 139 skipped (full report)


Code coverage* (full report)

  • functions: 28.2% (6331 of 22469 functions)
  • lines: 47.0% (44525 of 94665 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
186a34b at 2024-03-28T17:36:18.903Z :recycle:

Copy link
Contributor

@save-buffer save-buffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a simple way to add a test to this? If it's not easy to do then maybe not worth it to add one, but just a thought

@skyzh
Copy link
Member Author

skyzh commented Mar 26, 2024

Is there a simple way to add a test to this? If it's not easy to do then maybe not worth it to add one, but just a thought

Could be part of the compatibility test, I can give a try.

@skyzh
Copy link
Member Author

skyzh commented Mar 26, 2024

added test case in e6cbf6b 402829d

@skyzh skyzh requested a review from save-buffer March 26, 2024 18:42
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/allow-neon-ext-upgrade branch from e6cbf6b to 402829d Compare March 26, 2024 19:11
Copy link
Contributor

@save-buffer save-buffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@skyzh skyzh enabled auto-merge (squash) March 28, 2024 16:04
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh merged commit 90be79f into main Mar 28, 2024
47 of 48 checks passed
@skyzh skyzh deleted the skyzh/allow-neon-ext-upgrade branch March 28, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants