Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pagebench: fixup after is_rel_block_key changes in #6266 #6303

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

problame
Copy link
Contributor

@problame problame commented Jan 8, 2024

PR #6266 broke the getpage_latest_lsn benchmark.

Before this patch, we'd fail with

not implemented: split up range

because r.start = rel size key and r.end = rel size key + 1.

The filtering of the key ranges in that loop is a bit ugly, but,
I measured:

  • setup with 180k layer files (20k tenants * 9 layers).
  • total physical size is 463GiB
  • 5k tenants, the range filtering takes 0.6 seconds on an i3en.3xlarge.
    That's a tiny fraction of the overall time it takes for pagebench to get ready to send requests. So, this is good enough for now / there are other bottlenecks that are bigger.

PR #6266 broke the getpage_latest_lsn benchmark.

Before this patch, we'd fail with

```
not implemented: split up range
```

because `r.start = rel size key` and `r.end = rel size key + 1`.
@problame problame changed the base branch from problame/fix-6298 to main January 8, 2024 19:07
@problame problame requested a review from jcsp January 8, 2024 19:35
@problame problame marked this pull request as ready for review January 8, 2024 19:35
@problame problame requested review from a team as code owners January 8, 2024 19:35
@problame problame requested review from knizhnik and removed request for a team January 8, 2024 19:35
Copy link

github-actions bot commented Jan 8, 2024

2238 tests run: 2154 passed, 0 failed, 84 skipped (full report)


Flaky tests (2)

Postgres 16

  • test_pageserver_init_node_id: debug

Postgres 15

  • test_crafted_wal_end[last_wal_record_crossing_segment]: debug

Code coverage (full report)

  • functions: 54.8% (10145 of 18521 functions)
  • lines: 81.6% (58142 of 71265 lines)

The comment gets automatically updated with the latest test results
51666d1 at 2024-01-08T20:10:12.819Z :recycle:

@problame problame merged commit 4e1b0b8 into main Jan 9, 2024
46 checks passed
@problame problame deleted the problame/benchmarking/pr/fixup-fix-6210 branch January 9, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants