Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: use tenant_create() helper in test_bulk_insert #6064

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Dec 7, 2023

Problem

Since #5449 we enable generations in tests by default. Running benchmarks was missed while merging that PR, and there was one that needed updating.

Summary of changes

Make test_bulk_insert use the proper generation-aware helper for tenant creation.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added a/test Area: related to testing a/tech_debt Area: related to tech debt run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label labels Dec 7, 2023
@jcsp jcsp requested a review from bayandin December 7, 2023 13:53
@jcsp jcsp marked this pull request as ready for review December 7, 2023 13:53
Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests work 👍

@jcsp jcsp enabled auto-merge (squash) December 7, 2023 14:25
Copy link

github-actions bot commented Dec 7, 2023

2528 tests run: 2426 passed, 0 failed, 102 skipped (full report)


Flaky tests (5)

Postgres 16

  • test_ondemand_download_timetravel[mock_s3]: debug
  • test_pitr_gc: debug

Postgres 15

  • test_statvfs_pressure_min_avail_bytes: debug
  • test_gc_cutoff: debug

Postgres 14

  • test_statvfs_pressure_usage: debug

Code coverage (full report)

  • functions: 54.8% (9380 of 17112 functions)
  • lines: 82.3% (54247 of 65947 lines)

The comment gets automatically updated with the latest test results
e211548 at 2023-12-07T14:46:34.506Z :recycle:

@jcsp jcsp merged commit 880663f into main Dec 7, 2023
42 checks passed
@jcsp jcsp deleted the jcsp/tests-bulk-insert-gens branch December 7, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt a/test Area: related to testing run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants