init logical size: infallible accessor + type-level cleanups #5999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problame
requested review from
knizhnik
and removed request for
a team and
knizhnik
koivunej
reviewed
Nov 30, 2023
koivunej
approved these changes
Nov 30, 2023
2430 tests run: 2334 passed, 0 failed, 96 skipped (full report)Flaky tests (8)Postgres 16
Postgres 15Postgres 14Code coverage (full report)
The comment gets automatically updated with the latest test results
9275824 at 2023-12-01T13:07:57.997Z :recycle: |
... by panicking on overflow; It was made fallible initially due to in-confidence in logical size calculation. However, the error has never happened since I am at Neon. Let's stop worrying about this by converting the overflow check into a panic.
…5999) I would love to not expose the in-accurate value int he mgmt API at all, and in fact control plane doesn't use it [^1]. But our tests do, and I have no desire to change them at this time. [^1]: neondatabase/cloud#8317
problame
force-pushed
the
problame/init-logical-size-cleanups
branch
from
8d427ea to
9275824
Compare
problame
added a commit
that referenced
this pull request
Dec 1, 2023
... by panicking on overflow; It was made fallible initially due to in-confidence in logical size calculation. However, the error has never happened since I am at Neon. Let's stop worrying about this by converting the overflow check into a panic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked atop #5995 for no particular reason.