-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove unnecessary unsafe #5802
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up: that's my fault for adding some Send/Sync in some earlier variant of the code & not removing it later.
(moving the comment for walredo pre_exec soon, checking out other unsafety) |
also adding the deny into |
2358 tests run: 2243 passed, 0 failed, 115 skipped (full report)Flaky tests (2)Postgres 16
Postgres 14
Code coverage (full report)
The comment gets automatically updated with the latest test results
6ca3c27 at 2023-11-07T10:19:41.395Z :recycle: |
I cannot find a way to add these to |
349c8d9
to
6ca3c27
Compare
unsafe impls for
Send
andSync
should not be added by default. in the case ofSlotGuard
removing them does not cause any issues, as the compiler automatically derives those.This PR adds requirement to document the unsafety (see clippy::undocumented_unsafe_blocks) and opportunistically adds
#![deny(unsafe_code)]
to most places where we don't have unsafe code right now.TRPL on Send and Sync: https://doc.rust-lang.org/book/ch16-04-extensible-concurrency-sync-and-send.html