Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: improve the shutdown log error #5792

Merged
merged 2 commits into from
Nov 7, 2023
Merged

pageserver: improve the shutdown log error #5792

merged 2 commits into from
Nov 7, 2023

Conversation

duguorong009
Copy link
Contributor

@duguorong009 duguorong009 commented Nov 6, 2023

Problem

Summary of changes

  • Update the GetActiveTenantError -> QueryError conversion process in pageserver/src/page_service.rs
  • Update the pytest logging exceptions in ./test_runner/regress/test_tenant_detach.py

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp
Copy link
Collaborator

jcsp commented Nov 6, 2023

Thanks for opening this: it's doing the right thing, but will need a small update after #5367 merges, since that modifies how the error type works: GetActiveTenantError gets explicit WillNotBecomeActive and Cancelled variants, so the change to from() will need to handle those.

I should have mentioned in the original issue that this was follow-on for 5367 -- I didn't anticipate anyone being to fast to open a PR for it :-) (but it's appreciated!)

@duguorong009 duguorong009 requested a review from jcsp November 6, 2023 14:42
@duguorong009 duguorong009 marked this pull request as ready for review November 6, 2023 15:12
@duguorong009 duguorong009 requested a review from a team as a code owner November 6, 2023 15:12
@duguorong009 duguorong009 requested review from koivunej and removed request for a team November 6, 2023 15:12
@duguorong009
Copy link
Contributor Author

@jcsp
Can you add approved-for-ci-run label for CI running & merge if you think PR is ready?

@jcsp jcsp added the approved-for-ci-run Changes are safe to trigger CI for the PR label Nov 7, 2023
@github-actions github-actions bot removed the approved-for-ci-run Changes are safe to trigger CI for the PR label Nov 7, 2023
@vipvap vipvap mentioned this pull request Nov 7, 2023
@jcsp jcsp enabled auto-merge (squash) November 7, 2023 16:20
Copy link

github-actions bot commented Nov 7, 2023

2370 tests run: 2255 passed, 0 failed, 115 skipped (full report)


Flaky tests (3)

Postgres 14

  • test_crafted_wal_end[last_wal_record_xlog_switch_ends_on_page_boundary]: debug
  • test_eviction_across_generations: debug
  • test_timeline_deletion_with_files_stuck_in_upload_queue: debug

Code coverage (full report)

  • functions: 54.8% (8904 of 16257 functions)
  • lines: 81.7% (51275 of 62762 lines)

The comment gets automatically updated with the latest test results
14f3f4f at 2023-11-07T16:54:09.961Z :recycle:

@jcsp jcsp merged commit 11d9d80 into neondatabase:main Nov 7, 2023
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pageserver: don't log error when shutting down tenant during page_service request
2 participants