test: Remote storage refactorings #5243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if we are to have separate methods for pageserver, extensions, and safekeeper, we will have 3*3 methods. nobody has time for those.
koivunej
force-pushed
the
remote_storage_refactorings_cleaned_up
branch
from
090b6cb to
2c37fc0
Compare
1640 tests run: 1567 passed, 0 failed, 73 skipped (full report)Code coverage (full report)
The comment gets automatically updated with the latest test results
eaa4c82 at 2023-09-08T10:47:04.474Z :recycle: |
bayandin
approved these changes
Sep 7, 2023
Co-authored-by: Alexander Bayandin <alexander@neon.tech>
koivunej
force-pushed
the
remote_storage_refactorings_cleaned_up
branch
from
af70263 to
ce1d097
Compare
koivunej
force-pushed
the
remote_storage_refactorings_cleaned_up
branch
from
ce1d097 to
e952ea3
Compare
koivunej
commented
Sep 8, 2023
koivunej
commented
Sep 8, 2023
koivunej
commented
Sep 8, 2023
This was referenced Sep 8, 2023
koivunej
added a commit
that referenced
this pull request
Sep 8, 2023
I forgot a `str(...)` conversion in #5243. This lead to log lines such as: ``` Using fs root 'PosixPath('/tmp/test_output/test_backward_compatibility[debug-pg14]/compatibility_snapshot/repo/local_fs_remote_storage/pageserver')' as a remote storage ``` This surprisingly works, creating hierarchy of under current working directory (`repo_dir` for tests): - `PosixPath('` - `tmp` .. up until .. `local_fs_remote_storage` - `pageserver')` It should not work but right now test_compatibility.py tests finds local metadata and layers, which end up used. After #5172 when remote storage is the source of truth it will no longer work.
koivunej
added a commit
that referenced
this pull request
Sep 28, 2023
Part of #5172. Builds upon #5243, #5298. Includes the test changes: - no more RemoteStorageKind.NOOP - no more testing of pageserver without remote storage - benchmarks now use LOCAL_FS as well Support for running without RemoteStorage is still kept but in practice, there are no tests and should not be any tests. Co-authored-by: Christian Schwarz <christian@neon.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote storage cleanup split from #5198:
repo_dir / "local_fs_remote_storage" / $useris used as path, where $user ispageserver,safekeeperNeonEnvBuilder.enable_xxx_remote_storagebut oneenable_{pageserver,extensions,safekeeper}_remote_storageShould not have any real changes. These will allow us to default to
LOCAL_FSfor pageserver on the next PR, removeRemoteStorageKind.NOOP, work towards #5172.