Generate safekeeper unique IDs. #1081
Conversation
|
@lubennikovaav Please review the second patch. |
Immediate goal is to distinguish neighbours in peer-to-peer communication, but this is generally useful.
Timeline is active whenever there is at least 1 connection from compute or pageserver is not caught up. Currently 'active' means callmemaybes are being sent; later it would also manage gossip. Fixes race: now suspend condition checking and callmemaybe unsubscribe happen under the same lock.
|
Some time ago we discussed introducing ids to pageservers too. Maybe worth it to share some code (at least keep that in mind). Also I think it is ok to use ids created in console, i e when new safekeeper is added to control plane it is being assigned an id and for ease of debugging we can use this id. Thoughts? I think it is preferable to keep this id in config for simplicity and to avoid unsafe. |
|
Sure, code can be reused for pageserver, perhaps with edits. Yes, assigning from console sounds handy, but I'd still keep the code for generating it internally for tests and development. Well, keeping it in config means config must be passed everywhere, I wouldn't call it simpler. But would work too. |
Agree, something like generating the id if it is missing.
I think there wouldn't be too many places. Just like with no-sync option. Also I think this is cleaner because this way we keep everything config like in config. Another way to avoid unsafe is to use lazy_static or once_cell (or Box::leak as it is done for config in pageserver) |
|
Superseded by #1228 |
Immediate goal is to distinguish neighbours in peer-to-peer communication, but
this is generally useful.