Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase neon_local http client to compute timeout in reconfigure. #10088

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

arssher
Copy link
Contributor

@arssher arssher commented Dec 11, 2024

Seems like 30s sometimes not enough when CI runners are overloaded, causing pull_timeline flakiness.

ref #9731 (comment)

Seems like 30s sometimes not enough when CI runners are overloaded,
causing pull_timeline flakiness.

ref #9731 (comment)
@arssher arssher requested a review from arpad-m December 11, 2024 13:14
Copy link
Member

@arpad-m arpad-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try it, but I doubt this is the actual bug: in theory it shouldn't take that long to switch configurations. I think there is still some underlying bug here.

@arssher
Copy link
Contributor Author

arssher commented Dec 11, 2024

I agree that it's a bit suspicious, but let's try increasing and return if it doesn't help.

Copy link

github-actions bot commented Dec 11, 2024

7099 tests run: 6784 passed, 0 failed, 315 skipped (full report)


Flaky tests (4)

Postgres 17

Postgres 16

  • test_pgdata_import_smoke[None-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]: release-arm64

Code coverage* (full report)

  • functions: 31.4% (8340 of 26538 functions)
  • lines: 47.7% (65682 of 137635 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
bb45db3 at 2024-12-11T15:56:49.826Z :recycle:

@arssher arssher enabled auto-merge December 11, 2024 14:45
@arssher arssher added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit e4bb1ca Dec 11, 2024
84 checks passed
@arssher arssher deleted the test-pull-timeline-flakiness branch December 11, 2024 15:47
@arssher arssher restored the test-pull-timeline-flakiness branch December 12, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants