pageserver: fix buffered-writer on macos build #10019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pageserver: fix buffered-writer on macos build Signed-off-by: Yuchen Liang <yuchen@neon.tech>
yliang412
added
the
run-extra-build-macos
jcsp
approved these changes
Dec 4, 2024
7040 tests run: 6732 passed, 0 failed, 308 skipped (full report)Flaky tests (5)Postgres 17
Postgres 16
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
655d9b8 at 2024-12-04T21:04:40.853Z :recycle: |
bayandin
approved these changes
Dec 5, 2024
awarus
pushed a commit
that referenced
this pull request
Dec 5, 2024
## Problem In #9693, we forgot to check macos build. The [CI run](https://github.com/neondatabase/neon/actions/runs/12164541897/job/33926455468) on main showed that macos build failed with unused variables and dead code. ## Summary of changes - add `allow(dead_code)` and `allow(unused_variables)` to the relevant code that is not used on macos. Signed-off-by: Yuchen Liang <yuchen@neon.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In #9693, we forgot to check macos build. The CI run on main showed that macos build failed with unused variables and dead code.
Summary of changes
allow(dead_code)andallow(unused_variables)to the relevant code that is not used on macos.