chore: Reorganize and refresh CODEOWNERS #10008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ololobus
commented
Dec 4, 2024
jcsp
approved these changes
Dec 4, 2024
7040 tests run: 6732 passed, 0 failed, 308 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
6b9cff8 at 2024-12-05T19:11:29.490Z :recycle: |
We didn't have a codeowner for `/compute`, so nobody was auto-assigned for PRs like #9973 While on it: 1. Group codeowners into sections. 2. Remove control plane from the `/compute_tools` because it's primarily the internal `compute_ctl` code. 3. Add control plane (and compute) to `/libs/compute_api` because that's the shared public interface of the compute.
ololobus
force-pushed
the
alexk/compute-codeowners
branch
from
196e1fa to
6b9cff8
Compare
clipperhouse
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We didn't have a codeowner for
/compute, so nobody was auto-assigned for PRs like #9973Summary of changes
While on it:
/compute_toolsbecause it's primarily the internalcompute_ctlcode./libs/compute_apibecause that's the shared public interface of the compute.