pageserver: generation numbers for manifest objects #9543
Assignees
Labels
c/storage/pageserver
Component: storage: pageserver
t/feature
Issue type: feature, for new features or requests
Comments
jcsp
added
t/feature
This was referenced Oct 28, 2024
5 tasks
jcsp
added a commit
that referenced
this issue
Oct 29, 2024
## Problem Indices used to be the only kind of object where we had to search across generations to find the most recent one. As of #9543, manifests will need the same treatment. ## Summary of changes - Refactor download_index_part to a generic download_generation_object function, which will be usable for downloading manifest objects as well.
|
Second PR: #9555 |
5 tasks
jcsp
added a commit
that referenced
this issue
Oct 31, 2024
## Problem The final part of #9543 will be a chaos test that creates/deletes/archives/offloads timelines while restarting pageservers and migrating tenants. Developing that test showed up a few places where we log errors during normal shutdown. ## Summary of changes - UninitializedTimeline's drop should log at info severity: this is a normal code path when some part of timeline creation encounters a cancellation `?` path. - When offloading and finding a `RemoteTimelineClient` in a non-initialized state, this is not an error and should not be logged as such. - The `offload_timeline` function returned an anyhow error, so callers couldn't gracefully pick out cancellation errors from real errors: update this to have a structured error type and use it throughout.
|
The missing item here is tests, which will be addressed by #9609 |
|
The PR merged, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: