Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanups following removal of metadata file #6890

Closed
problame opened this issue Feb 23, 2024 · 1 comment · Fixed by #7752
Closed

cleanups following removal of metadata file #6890

problame opened this issue Feb 23, 2024 · 1 comment · Fixed by #7752
Assignees
@jcsp
Labels
c/storage/pageserver Component: storage: pageserver

Comments

@problame
Copy link
Contributor

problame commented Feb 23, 2024 •
edited by jcsp
Loading

This is follow-up to #6769 once it has been rolled out and we won't roll it back.
@problame problame added the c/storage/pageserver Component: storage: pageserver label Feb 23, 2024
@problame problame self-assigned this Feb 23, 2024
This was referenced Feb 23, 2024
Merged
Closed
problame added a commit that referenced this issue Feb 23, 2024
@problame
stop writing metadata file (#6769)
cd449d6 
Building atop #6777, this PR removes the code that writes the `metadata`
file and adds a piece of migration code that removes any remaining
`metadata` files.

We'll remove the migration code after this PR has been deployed.

part of #6663

More cleanups punted into follow-up issue, as they touch a lot of code: 
#6890
@problame problame mentioned this issue Apr 12, 2024
Closed
@problame problame removed their assignment Apr 30, 2024
@jcsp
Copy link
Collaborator

jcsp commented May 13, 2024

Starting the process of making remote storage mandatory here: #7722

We can require it in the config, and then proceed to weed out all the places where we have a spurious Option<> that's always Some.

@jcsp jcsp self-assigned this May 14, 2024
@jcsp jcsp mentioned this issue May 15, 2024
Merged
5 tasks
jcsp added a commit that referenced this issue May 15, 2024
@jcsp
pageserver: remove Option<> around remote storage, clean up metadata …
f342b87 
…file refs (#7752)

## Problem

This is historical baggage from when the pageserver could be run with
local disk only: we had a bunch of places where we had to treat remote
storage as optional.

Closes: #6890

## Changes

- Remove Option<> around remote storage (in
#7722 we made remote storage
clearly mandatory)
- Remove code for deleting old metadata files: they're all gone now.
- Remove other references to metadata files when loading directories, as
none exist.

I checked last 14 days of logs for "found legacy metadata", there are no
instances.
a-masterov pushed a commit that referenced this issue May 20, 2024
@jcsp @a-masterov
pageserver: remove Option<> around remote storage, clean up metadata …
0fa6af3 
…file refs (#7752)

## Problem

This is historical baggage from when the pageserver could be run with
local disk only: we had a bunch of places where we had to treat remote
storage as optional.

Closes: #6890

## Changes

- Remove Option<> around remote storage (in
#7722 we made remote storage
clearly mandatory)
- Remove code for deleting old metadata files: they're all gone now.
- Remove other references to metadata files when loading directories, as
none exist.

I checked last 14 days of logs for "found legacy metadata", there are no
instances.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcsp jcsp

Labels
c/storage/pageserver Component: storage: pageserver
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pageserver: remove Option<> around remote storage, clean up metadata file refs neondatabase/neon
2 participants
@jcsp @problame