Skip to content

Commit

Permalink
fix(pagebench): #6325 broke running without --runtime (#6351)
Browse files Browse the repository at this point in the history
After PR #6325, when running without --runtime, we wouldn't wait for
start_work_barrier, causing the benchmark to not start at all.
  • Loading branch information
problame authored Jan 15, 2024
1 parent 31a4eb4 commit 0e1ef37
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pageserver/pagebench/src/cmd/getpage_latest_lsn.rs
Original file line number Diff line number Diff line change
Expand Up @@ -349,10 +349,10 @@ async fn main_impl(

let work_sender_task = tokio::spawn(work_sender);

info!("waiting for everything to become ready");
start_work_barrier.wait().await;
info!("work started");
if let Some(runtime) = args.runtime {
info!("waiting for everything to become ready");
start_work_barrier.wait().await;
info!("work started");
tokio::time::sleep(runtime.into()).await;
info!("runtime over, signalling cancellation");
cancel.cancel();
Expand Down

1 comment on commit 0e1ef37

@github-actions
Copy link

@github-actions github-actions bot commented on 0e1ef37 Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2318 tests run: 2227 passed, 0 failed, 91 skipped (full report)


Flaky tests (3)

Postgres 15

  • test_tenant_delete_races_timeline_creation: debug
  • test_empty_tenant_size: debug

Postgres 14

  • test_no_config[None]: debug

Code coverage (full report)

  • functions: 54.6% (10216 of 18705 functions)
  • lines: 81.5% (58706 of 72018 lines)

The comment gets automatically updated with the latest test results
0e1ef37 at 2024-01-15T11:27:47.320Z :recycle:

Please sign in to comment.