neonvm: Make spec min/max/use resources required #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This already was de-facto the case, which made much of the logic around handling "but what if .max is nil?" somewhat hard to reason about. Extracted from #970 and fleshed out here. All our staging & production clusters have VMs meeting this criteria, with the notable exception of a single, already-broken VM in dev-us-east-2-beta. More here: https://neondb.slack.com/archives/C03TN5G758R/p1718742308251569 --- Checked each cluster with: kubectl get neonvm -o json \ | jq -r '.items[] | select(.spec.guest | [.cpus.max,.cpus.min,.memorySlots.max,.memorySlots.min] | map(select(. == null)) | (length != 0)) | .metadata.name'
5 tasks
Omrigan
approved these changes
Jun 19, 2024
sharnoff
changed the title
sharnoff
added a commit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This already was de-facto the case, which made much of the logic around handling "but what if .max is nil?" somewhat tricky to reason about.
Extracted from #970 and fleshed out here.
All our staging & production clusters have VMs meeting this criteria, with the notable exception of a single, already-broken VM in dev-us-east-2-beta (it's a long story).
More here: https://neondb.slack.com/archives/C03TN5G758R/p1718742308251569
Checked each cluster with: