Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to set the asset root used for asset downloads explicitly. #56

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

shartte
Copy link
Collaborator

@shartte shartte commented Jan 3, 2025

The use cases I see:

  • Setting NFRT_ASSET_ROOT via Github Action to use a cache directory that is cross-branch, since the MC assets do not change that much from version to version.
  • Setting NFRT_ASSET_REPOSITORY for people that want to use a local proxy (we might also use a pull-through HTTP proxy for assets).

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jan 3, 2025

  • Publish PR to GitHub Packages

Last commit published: 62b609e65fa83d066935f79505b99c308a6ac3f3.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #56' // https://github.com/neoforged/NeoFormRuntime/pull/56
        url 'https://prmaven.neoforged.net/NeoFormRuntime/pr56'
        content {
            includeModule('net.neoforged', 'neoform-runtime')
        }
    }
}

@shartte shartte changed the title Add support to set the used asset root. Add support to set the asset root used for asset downloads explicitly. Jan 3, 2025
@Matyrobbrt Matyrobbrt merged commit b462ded into main Jan 7, 2025
3 checks passed
@Matyrobbrt Matyrobbrt deleted the fixed-asset-root branch January 7, 2025 21:45
@neoforged-releases
Copy link

🚀 This PR has been released as NeoFormRuntime version 1.0.19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants