Add dynamic version support #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shartte
commented
Jan 2, 2025
shartte
commented
- It will first try to find the dynamic version in the artifact manifest
- If that fails, it gathers all available versions from across all repositories (uncached) and then substitutes the best matching version
Last commit published: 52d8308547e04253cdf8cf88dbe274352bfa4f35. PR PublishingThe artifacts published by this PR:Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #55' // https://github.com/neoforged/NeoFormRuntime/pull/55
url 'https://prmaven.neoforged.net/NeoFormRuntime/pr55'
content {
includeModule('net.neoforged', 'neoform-runtime')
}
}
} |
Matyrobbrt
requested changes
Jan 7, 2025
| var finalLocation = artifactsCache.resolve(mavenCoordinate.toRelativeRepositoryPath()); | ||
|
|
||
| // Special case: NeoForge reference libraries that are only available via the Mojang download server | ||
| if (mavenCoordinate.groupId().equals("com.mojang") && mavenCoordinate.artifactId().equals("logging")) { | ||
| if (mavenCoordinate.groupId().equals("com.mojang") && mavenCoordinate.artifactId().equals("logging") |
There was a problem hiding this comment.
I'm being pedantic but I would surround the ands in their own parenthesis for clarity's sake
| // See if it's a dynamic version and match against all entries | ||
| if (artifactCoordinate.isDynamicVersion()) { | ||
| for (var entry : externallyProvided.entrySet()) { | ||
| if (artifactCoordinate.matchesVersion(entry.getKey().version()) |
There was a problem hiding this comment.
I think this check should be matches artifact first and version second
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.