Fix the logic of running internal tools using the host JRE being inverted #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last commit published: 9d2e70607fa1d105ad87188f6cd4a398009f35b7. PR PublishingThe artifacts published by this PR:Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #48' // https://github.com/neoforged/NeoFormRuntime/pull/48
url 'https://prmaven.neoforged.net/NeoFormRuntime/pr48'
content {
includeModule('net.neoforged', 'neoform-runtime')
}
}
} |
Technici4n
approved these changes
Dec 9, 2024
|
🚀 This PR has been released as NeoFormRuntime version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works exactly opposite to what was intended.
Internal tools like JST/DiffPatch should run with NFRTs JRE, even if we're running MCP for Java 1.8, while the tools from that MCP config should run with Java 1.8. The toggle currently does the exact opposite of that.