Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for stripping Jar signatures when recompiling/remapping Forge #47

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

shartte
Copy link
Collaborator

@shartte shartte commented Dec 7, 2024

In "legacy" mode, we don't copy over the modding platform Jar unmodified, instead we remap and recompile the source files while copying over resources.

This breaks the Jar signatures contained in the MANIFEST.MF, so we need to do the following:

  • Don't copy signature related resources (META-INF/*.{SF,RSA,EC,DSA})
  • Filter out any digests from the MANIFEST.MF we copy (since the SHA-256 values will obviously differ after remapping/recompiling)
  • While we're at it, don't try to copy the bogus MANIFEST.MF from the source artifact

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Dec 7, 2024

  • Publish PR to GitHub Packages

Last commit published: c1bc942ce3e7ccab13b96bdd1cf622bdb454be4f.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #47' // https://github.com/neoforged/NeoFormRuntime/pull/47
        url 'https://prmaven.neoforged.net/NeoFormRuntime/pr47'
        content {
            includeModule('net.neoforged', 'neoform-runtime')
        }
    }
}

@shartte shartte requested a review from Matyrobbrt December 7, 2024 11:45
@shartte shartte merged commit d0ac31e into main Dec 7, 2024
2 checks passed
@shartte shartte deleted the strip-jarsigning-signatures branch December 7, 2024 12:00
@neoforged-releases
Copy link

🚀 This PR has been released as NeoFormRuntime version 1.0.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants