-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename slimeball tag, melee tools adjustment, and fix entries for some biome and food tags #1372
rename slimeball tag, melee tools adjustment, and fix entries for some biome and food tags #1372
Conversation
Last commit published: deedfce2ddb69235f94fbef03eecb5c469bfbcce. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1372' // https://github.com/neoforged/NeoForge/pull/1372
url 'https://prmaven.neoforged.net/NeoForge/pr1372'
content {
includeModule('net.neoforged', 'neoforge')
includeModule('net.neoforged', 'testframework')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1372
cd NeoForge-pr1372
curl -L https://prmaven.neoforged.net/NeoForge/pr1372/net/neoforged/neoforge/21.0.159-pr-1372-SlimeToolsAndFixesTags/mdk-pr1372.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
Fabric side reach agreement and was merged. Merging this now |
src/main/java/net/neoforged/neoforge/common/data/internal/NeoForgeItemTagsProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/common/data/internal/NeoForgeItemTagsProvider.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge at will.
Hold on merging until I give approval
Last PR was merged accidentally too early: #1348
There was still more discussions to be done. Changes here are:
Added Old Growth Spruce Taiga, Windswept Hills, Windswept Gravelly Hills, Windswept Forest, and Stony Shores to the
c:is_cold/overworld
tag.Moved Melon Slice from
c:foods/vegetable
toc:foods/fruit
as melons are usually considered fruits.Removed Glistering Melon Slice from
c:foods/golden
because it is not actually edible and thus, not food.Melee weapon tag no longer has pickaxes, hoes, or shovels in it. And clarified the melee weapon tag's javadoc to make it clear pickaxes are excluded because being a weapon is not a pickaxe's primary purpose.
rename
c:slimeballs
toc:slime_balls
and deprecate the older tag. The tag name is closer match to vanilla slime ball registry name. The translation name would have no space to match vanilla slimeball translation name