Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rm yarn, use npm #4741

Merged
merged 4 commits into from
Sep 1, 2023
Merged

feat: rm yarn, use npm #4741

merged 4 commits into from
Sep 1, 2023

Conversation

fannheyward
Copy link
Member

@fannheyward fannheyward commented Sep 1, 2023

Remove yarn totally, use npm instead.

After we upgrade glob to v10 34f5d96, this uses jackspeak , and cliui, which uses an renamed string-width that broken testing work. isaacs/jackspeak#5

To fix this issue, use an earlier glob, or upgrade to yarn 3. This won't be fixed with yarn 1.

I've tested several ways yesterday:

  1. remove yarn 1, use npm.
    • pros: yarn 1 is dead, long live npm
    • cons: breaking change for master users
  2. use glob@9, also supports signal that to fix Suppress scandir access error in /tmp dir #4538
    • pros: no jackspeak, no breaks for anything
    • cons: lock to glob@9
  3. we've upgraded node to v16.18, we can use corepack to use yarn 3: corepack enable; corepack prepare yarn@3.6.3 --activate
    • pros: still use yarn, no more yarn 1 issues
    • cons: needs steps to enable yarn with corepack
  4. I also tested with pnpm because more frontend projects like vue uses this, we can also use corepack to enable this
    • pros: no more yarn 1 issues, more modernize?
    • cons: needs steps to enable it, change our CI, development

Because yarn 1 is dead, I prefer to use npm, remove all yarn scripts.

15c8946#commitcomment-126134192

@fannheyward
Copy link
Member Author

cc @chemzqm @yaegassy

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (c7d73df) 98.73% compared to head (4b1284d) 98.71%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4741      +/-   ##
==========================================
- Coverage   98.73%   98.71%   -0.02%     
==========================================
  Files         273      273              
  Lines       25928    25928              
  Branches     5378     5378              
==========================================
- Hits        25599    25596       -3     
- Misses        191      192       +1     
- Partials      138      140       +2     
Files Changed Coverage Δ
src/extension/index.ts 100.00% <100.00%> (ø)
src/workspace.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fannheyward fannheyward requested a review from chemzqm September 1, 2023 03:57
@fannheyward
Copy link
Member Author

User can still use yarn or cnpm with npm.binPath to install extensions.

@fannheyward fannheyward changed the title chore: rm yarn, use npm feat: rm yarn, use npm Sep 1, 2023
@chemzqm chemzqm merged commit 5347239 into master Sep 1, 2023
@chemzqm chemzqm deleted the chore/rm-yarn branch September 1, 2023 10:18
chemzqm added a commit that referenced this pull request Sep 3, 2023
17fe9d3 fix(vim): avoid throw error with Vim prefix
44539bd fix(format): avoid backslash on vim9script
654083c fix(highlight): add list highlight before VimEnter
fab88b2 fix(plugin): enable static highlight groups before VimEnter
5353e87 feat(list): support g:coc_list_preview_filetype
5347239 feat: rm yarn, use npm (#4741)
1c4dbc9 feat(completion): support suggest.removeCurrentWord
8fcbc01 fix(document): avoid undefined line
6bb2e21 refactor(inlayHint): use api buffer.setVirtualText
0c2c64c fix(list): possible wrong height with winbar enabled
09e0c00 chore(doc): improve doc of CocCommand
c7d73df chore(doc): documents snippetCancel action
shirayu added a commit to shirayu/dot_vim that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress scandir access error in /tmp dir
2 participants