chore(CI): use Node 20

nodejs/node#52079
neoclide · Mar 14, 2024 · 7f2b182 · 7f2b182
1 parent 84ce031
commit 7f2b182
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -21,23 +21,23 @@ jobs:
           - "stable"
           - "nightly"
         node:
-          - "16"
+          - "20"
         include:
           # only enable coverage on the fastest job
-          - node: "16"
+          - node: "20"
             ENABLE_CODE_COVERAGE: true
 
     env:
       NODE_ENV: test
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 2
 
       - name: Setup Node.js ${{ matrix.node }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node }}
           cache: "npm"

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -15,10 +15,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setup Node.js
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           cache: "npm"
 

diff --git a/src/configuration/shape.ts b/src/configuration/shape.ts
@@ -34,7 +34,7 @@ export default class ConfigurationProxy implements IConfigurationShape {
     let dir = path.dirname(fsPath)
     let formattingOptions = { tabSize: 2, insertSpaces: true }
     if (!fs.existsSync(dir)) fs.mkdirSync(dir, { recursive: true })
-    let content = fs.readFileSync(fsPath, { encoding: 'utf8', flag: 'a+' })
+    let content = fs.readFileSync(fsPath, { flag: 'a+' }).toString('utf8')
     content = content || '{}'
     let edits = modify(content, [key], value, { formattingOptions })
     content = applyEdits(content, edits)