Refactored rviz launch file

[AdarshKaran]

• Refactored the rviz_launch file to use opaque function
• Added additional launch argument to change the output type (screen, log) of RViz node

[padhupradheep]

LGTM! I see your idea of making it generic for all the robots. This means that we also have to add the rviz_launch.py to the navigation_neo.launch.py. By that way, we just have to add a single argument to our navigation.launch.py across the robots.

By default, use_rviz should be set to true on the navigation launch.

Did you have something else in mind?

[padhupradheep]

changelog will be generated by the bloom. Just make sure, your commits are descriptive.

[AdarshKaran]

LGTM! I see your idea of making it generic for all the robots. This means that we also have to add the rviz_launch.py to the navigation_neo.launch.py. By that way, we just have to add a single argument to our navigation.launch.py across the robots.

By default, use_rviz should be set to true on the navigation launch.

Did you have something else in mind?

• I have now added the start_rviz node to the navigation_neo.launch.py file and the necessary launch argument.
• I have also updated removed the additional RViz node from navigation.launch.py in ROX and instead added an argument to the navigation_neo.launch.py launch node which already exists.
• I have removed the changelogs