Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generators enhancements and fixes #1716

Closed
wants to merge 2 commits into from
Closed

generators enhancements and fixes #1716

wants to merge 2 commits into from

Conversation

mrhardikjoshi
Copy link
Member

@mrhardikjoshi mrhardikjoshi commented Jan 5, 2024

Note: PR #1717 includes all this pr's change + extra tests

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f86d54c) 93.12% compared to head (e055bff) 93.10%.

❗ Current head e055bff differs from pull request most recent head 95600ca. Consider uploading reports for the commit 95600ca to get more accurate results

Files Patch % Lines
lib/active_graph/railtie.rb 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##               11    #1716      +/-   ##
==========================================
- Coverage   93.12%   93.10%   -0.02%     
==========================================
  Files         128      128              
  Lines        5700     5700              
==========================================
- Hits         5308     5307       -1     
- Misses        392      393       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrhardikjoshi mrhardikjoshi changed the title WIP generators enhancements and fixes generators enhancements and fixes Jan 12, 2024
@mrhardikjoshi
Copy link
Member Author

closing because #1717 covers this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants