Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate multi-target routing driver #986

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Deprecate multi-target routing driver #986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/neo4j/_async/driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,15 @@ def neo4j_driver(cls, *targets, routing_context=None, **config):
""" Create a driver for routing-capable Neo4j service access
that uses socket I/O and thread-based concurrency.
"""

# TODO: 6.0 - adjust signature to only take one target
if len(targets) > 1:
deprecation_warn(
"Creating a routing driver with multiple targets is "
"deprecated. The driver only uses the first target anyway. "
"The method signature will change in a future release.",
)

from .._exceptions import (
BoltHandshakeError,
BoltSecurityError,
Expand Down
9 changes: 9 additions & 0 deletions src/neo4j/_sync/driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,15 @@ def neo4j_driver(cls, *targets, routing_context=None, **config):
""" Create a driver for routing-capable Neo4j service access
that uses socket I/O and thread-based concurrency.
"""

# TODO: 6.0 - adjust signature to only take one target
if len(targets) > 1:
deprecation_warn(
"Creating a routing driver with multiple targets is "
"deprecated. The driver only uses the first target anyway. "
"The method signature will change in a future release.",
)

from .._exceptions import (
BoltHandshakeError,
BoltSecurityError,
Expand Down