Fix bolt handshake not having a timeout #905
Merged
+131
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the bolt version negotiation the socket was not constrained by any timeout. This could, in rare occasions cause the driver to get stuck until some other mechanism (e.g., socket keep alive) would free it. The handshake is not limited by the `connection_acquisition_timeout`.
AndyHeap-NeoTech
approved these changes
Mar 30, 2023
robsdedude
added a commit
to robsdedude/neo4j-python-driver
that referenced
this pull request
Apr 11, 2023
This is a backport of neo4j#905
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the bolt version negotiation the socket was not constrained by any timeout. This could, in rare occasions, cause the driver to get stuck until some other mechanism (e.g., socket keep alive) would free it.
The handshake is now limited by the
connection_acquisition_timeout.Introducing tests in neo4j-drivers/testkit#546