Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make code compatible with mypy 0.990 #854

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Conversation

robsdedude
Copy link
Member

  • remove implicit optional parameters (PEP 484 received an update)
  • mute metaclass inference limitations of mypy
  • fix mypy rightfully complaining about empty method bodies
  • fixed bug in (deprecated) session.last_bookmark that mypy uncovered

 * remove implicit optional parameters (PEP 484 received an update)
 * mute metaclass inference limitations of mypy
 * fix mypy rightfully complaining about empty method bodies
 * fixed bug in (deprecated) `session.last_bookmark` that mypy uncovered
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

(Quite nice bug solved 🎁 )

@robsdedude robsdedude merged commit 64112ff into neo4j:5.0 Nov 9, 2022
@robsdedude robsdedude deleted the mypy-0.990 branch November 9, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants