Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove null handling for Node/Relationship Ids #737

Merged
merged 4 commits into from
Jul 6, 2022

Conversation

thelonelyvulpes
Copy link
Contributor

@thelonelyvulpes thelonelyvulpes commented Jun 1, 2022

Remove code for handling null ids inline with updated specification regarding node/ relationship ids

Amends #672

@robsdedude
Copy link
Member

The driver still assumes that with freki disabled str(id) == element_id, which is not the case and needs fixing.

It's not guaranteed that `element_id == str(id_)` if the server provides both.
@thelonelyvulpes thelonelyvulpes merged commit 2b4f1c7 into 5.0 Jul 6, 2022
@thelonelyvulpes thelonelyvulpes deleted the feature/remove-null-tests-for-ids branch July 6, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants