Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Notification.description polyfill from GqlStatusObject #1071

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

bigmontz
Copy link
Contributor

Bolt 5.6 introduces the original notification description back in the protocol level. This avoids the Notification.description changes when connected to GQL aware servers.

This issues was detected during homologation, so the problem won't happen with any released server since the bolt version which miss information will not be released.

Bolt 5.6 introduces the original notification description back in
the protocol level. This avoids the `Notification.description` changes
when connected to GQL aware servers.

This issues was detected during homologation, so the problem won't
happen with any released server since the bolt version which miss
information will not be released.
@bigmontz bigmontz requested a review from robsdedude July 23, 2024 15:10
Copy link
Contributor

@StephenCathcart StephenCathcart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@robsdedude robsdedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔔✍️

@robsdedude robsdedude merged commit 8420fc4 into neo4j:5.0 Jul 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants