fix: prevent exception caused by adding duplicate fields in schema generation #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-ince
approved these changes
Oct 18, 2024
fbiville
reviewed
Oct 18, 2024
| topics = | ||
| arrayOf( | ||
| CdcSourceTopic( | ||
| topic = "cdc", patterns = arrayOf(CdcSourceParam("(:TestSource)")))))) |
There was a problem hiding this comment.
quick q unrelated to the PR: can't the patterns attribute here just be an array of strings? the CdcSourceParam type seems a bit verbose to me here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where duplicate fields in the ChangeEvent schema generation process were causing
org.apache.kafka.connect.errors.SchemaBuilderException: Cannot create field because of field name duplication idexception. When building the schema for key array elements, if different maps contained the same field name, the field was being added multiple times, resulting in the exception.