Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tests from Java Driver to Testkit #985

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

injectives
Copy link
Contributor

@injectives injectives commented Aug 16, 2021

Cherry-pick: #982.

New features:

  • Temporary:DriverMaxTxRetryTime - configures maximum transaction retry time.

Replaced tests:

  • shouldCloseChannelWhenResetFails -> ChannelErrorHandler.channelInactive (existing unit test)

Migrated tests:

  • shouldRetryReadTransactionUntilFailure -> test_should_fail_when_reading_from_unexpectedly_interrupting_readers_using_tx_function
  • shouldRetryWriteTransactionUntilFailure -> test_should_fail_when_writing_to_unexpectedly_interrupting_writers_using_tx_function
  • useSessionAfterDriverIsClosed -> test_should_fail_when_driver_closed_using_session_run
  • shouldRejectConnectionsToNonNeo4jServers -> test_should_reject_server_using_verify_connectivity_bolt_3x0

New features:
- `Temporary:DriverMaxTxRetryTime` - configures maximum transaction retry time.

Replaced tests:
- shouldCloseChannelWhenResetFails -> ChannelErrorHandler.channelInactive (existing unit test)

Migrated tests:
- shouldRetryReadTransactionUntilFailure -> test_should_fail_when_reading_from_unexpectedly_interrupting_readers_using_tx_function
- shouldRetryWriteTransactionUntilFailure -> test_should_fail_when_writing_to_unexpectedly_interrupting_writers_using_tx_function
- useSessionAfterDriverIsClosed -> test_should_fail_when_driver_closed_using_session_run
@injectives injectives requested a review from gjmwoods August 16, 2021 12:12
@injectives injectives merged commit b8fb1e9 into neo4j:4.3 Aug 16, 2021
@injectives injectives deleted the feature/cpick branch August 16, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants