Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tests to Testkit #976

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

injectives
Copy link
Contributor

This updated also includes:

  • TransactionClose request support (Temporary:TransactionClose feature)
  • Driver fetch size configuration (Temporary:DriverFetchSize feature)

Migrated tests:

  • shouldThrowRollbackErrorWhenTransactionRollback -> test_should_error_on_rollback_failure_using_tx_rollback
  • shouldThrowRollbackErrorWhenTransactionClose -> test_should_error_on_rollback_failure_using_tx_close
  • shouldPropagateTransactionRollbackErrorWhenSessionClosed -> test_should_error_on_rollback_failure_using_session_close
  • shouldStreamingRecordsInBatches -> test_should_accept_custom_fetch_size_using_driver_configuration (protocol bump from 4 to 4.1)
  • shouldChangeFetchSize -> test_should_accept_custom_fetch_size_using_session_configuration (protocol bump from 4 to 4.1)

This updated also includes:
- TransactionClose request support (`Temporary:TransactionClose` feature)
- Driver fetch size configuration (`Temporary:DriverFetchSize` feature)

Migrated tests:
- shouldThrowRollbackErrorWhenTransactionRollback -> test_should_error_on_rollback_failure_using_tx_rollback
- shouldThrowRollbackErrorWhenTransactionClose -> test_should_error_on_rollback_failure_using_tx_close
- shouldPropagateTransactionRollbackErrorWhenSessionClosed -> test_should_error_on_rollback_failure_using_session_close
- shouldStreamingRecordsInBatches -> test_should_accept_custom_fetch_size_using_driver_configuration (protocol bump from 4 to 4.1)
- shouldChangeFetchSize -> test_should_accept_custom_fetch_size_using_session_configuration (protocol bump from 4 to 4.1)
@injectives injectives requested a review from gjmwoods August 11, 2021 09:28
@injectives injectives merged commit 7a824c5 into neo4j:4.4 Aug 11, 2021
@injectives injectives deleted the feature/stubtestsmigration branch August 11, 2021 11:22
injectives added a commit to injectives/neo4j-java-driver that referenced this pull request Aug 11, 2021
This updated also includes:
- TransactionClose request support (`Temporary:TransactionClose` feature)
- Driver fetch size configuration (`Temporary:DriverFetchSize` feature)

Migrated tests:
- shouldThrowRollbackErrorWhenTransactionRollback -> test_should_error_on_rollback_failure_using_tx_rollback
- shouldThrowRollbackErrorWhenTransactionClose -> test_should_error_on_rollback_failure_using_tx_close
- shouldPropagateTransactionRollbackErrorWhenSessionClosed -> test_should_error_on_rollback_failure_using_session_close
- shouldStreamingRecordsInBatches -> test_should_accept_custom_fetch_size_using_driver_configuration (protocol bump from 4 to 4.1)
- shouldChangeFetchSize -> test_should_accept_custom_fetch_size_using_session_configuration (protocol bump from 4 to 4.1)
injectives added a commit that referenced this pull request Aug 11, 2021
This updated also includes:
- TransactionClose request support (`Temporary:TransactionClose` feature)
- Driver fetch size configuration (`Temporary:DriverFetchSize` feature)

Migrated tests:
- shouldThrowRollbackErrorWhenTransactionRollback -> test_should_error_on_rollback_failure_using_tx_rollback
- shouldThrowRollbackErrorWhenTransactionClose -> test_should_error_on_rollback_failure_using_tx_close
- shouldPropagateTransactionRollbackErrorWhenSessionClosed -> test_should_error_on_rollback_failure_using_session_close
- shouldStreamingRecordsInBatches -> test_should_accept_custom_fetch_size_using_driver_configuration (protocol bump from 4 to 4.1)
- shouldChangeFetchSize -> test_should_accept_custom_fetch_size_using_session_configuration (protocol bump from 4 to 4.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants