Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce support for logging debug entries with Throwable #940

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

injectives
Copy link
Contributor

No description provided.

@injectives injectives force-pushed the feature/logdebugthrowable branch 2 times, most recently from 0a95a0d to 7b14fc1 Compare June 22, 2021 13:10
@injectives injectives force-pushed the feature/logdebugthrowable branch from 9399c41 to 8d29fa0 Compare June 22, 2021 16:33
Copy link
Contributor

@michael-simons michael-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I briefly thought why not adding the new method as default method to the logger interface but then, the default would only be sensible for the dev null logger.
So in the end: Nothing to complain, I'm sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants