Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make QueryRunner interface extend AutoCloseable #928

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Make QueryRunner interface extend AutoCloseable #928

merged 1 commit into from
Jun 16, 2021

Conversation

injectives
Copy link
Contributor

No description provided.

@injectives injectives force-pushed the feature/qrautoclosable branch from 1444c66 to 7cde5e3 Compare June 15, 2021 14:56
@injectives injectives changed the title Make QueryRunner interface extend AutoCloseable Make QueryRunner interface extend Resource that is also AutoCloseable Jun 15, 2021
@injectives injectives force-pushed the feature/qrautoclosable branch from 7cde5e3 to 0773770 Compare June 15, 2021 15:02
@injectives injectives changed the title Make QueryRunner interface extend Resource that is also AutoCloseable Make QueryRunner interface extend AutoCloseable Jun 15, 2021
michael-simons
michael-simons approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@michael-simons michael-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do appreciate that change a lot and for 4.3 this is great.

I wonder if we should - as you already hinted at - rethink this:

image

Transactions and sessions are both query runners and both resources. The interface inheritance should be a straight line in 5.0

@injectives
Copy link
Contributor Author

Thank you 👍 We should consider removing Resource in the next major release unless a reasonable use-case is discovered.

@injectives injectives merged commit 66db552 into neo4j:4.3 Jun 16, 2021
@injectives injectives deleted the feature/qrautoclosable branch June 16, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-simons michael-simons michael-simons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@injectives @michael-simons