Honor url whitelist when fetching remote grass files #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarhane
requested changes
Jun 26, 2017
| }) | ||
|
|
||
| describe('Grass remote fetch', () => { | ||
| test('should not fetch from url not in the whitelist', () => { |
There was a problem hiding this comment.
This test won't work if the function doesn't reject. Try changing urlNotInWhitelist = 'foo'.
Since Jest 20 you can return promises and expect it to reject. There's one missing piece though, you cannot match on error message. The workaround is to match an object and looks like this:
return expect(fetchRemoteGrass(urlNotInWhitelist, whitelist)).rejects.toMatchObject({
message: 'Hostname is not allowed according to server whitelist'
})
https://facebook.github.io/jest/docs/expect.html#resolves and jestjs/jest#3601
| const urlInWhitelist = 'foo' | ||
| return fetchRemoteGrass(urlInWhitelist, whitelist) | ||
| .then((res) => { | ||
| expect(res).toBe(urlInWhitelist) |
There was a problem hiding this comment.
Same as above, but using .resolves: https://facebook.github.io/jest/docs/expect.html#resolves
| @@ -207,7 +207,7 @@ const availableCommands = [{ | |||
| if (!param.startsWith('http')) { | |||
| param = 'http://' + param | |||
| } | |||
| remote.get(param) | |||
| fetchRemoteGrass(param) | |||
There was a problem hiding this comment.
Should the whitelist be passed as a param here?
|
@oskarhane updated |
oskarhane
approved these changes
Jun 29, 2017
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The url param when loading remote grass using
:styleneeds to be present in the whitelist returned by the neo4j server