Fix plan view for DbHits over 32 bit integer max #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarDamkjaer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the statistics from the driver are wrong for large numbers. It’s reproducible by calling
PROFILE MATCH (n:Person|Node) return count(*)on a database where you have over 32 bit signed integer max nodes (about two billion) with these labels. You’ll see that the rows & dbHits numbers will be negative.This is caused by a four year old dormant bug in the driver code, I've reached out to the drivers team and there was nothing preventing us from using this workaround until it is fixed in the driver.